perf: skip parsing If-None-Match when no ETag header

foxifyjs · Feb 19, 2017 · ec0e57b · ec0e57b
1 parent 2f11ec8
commit ec0e57b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/HISTORY.md b/HISTORY.md
@@ -3,6 +3,7 @@ unreleased
 
   * Fix incorrect result when `If-None-Match` has both `*` and ETags
   * Fix weak `ETag` matching to match spec
+  * perf: skip parsing `If-None-Match` when no `ETag` header
 
 0.4.0 / 2017-02-05
 ==================

diff --git a/index.js b/index.js
@@ -63,8 +63,7 @@ function fresh (reqHeaders, resHeaders) {
 
   // if-none-match
   if (noneMatch && noneMatch !== '*') {
-    noneMatch = noneMatch.split(TOKEN_LIST_REGEXP)
-    etagMatches = noneMatch.some(function (match) {
+    etagMatches = Boolean(etag) && noneMatch.split(TOKEN_LIST_REGEXP).some(function (match) {
       return match === etag || match === 'W/' + etag || 'W/' + match === etag
     })
   }