go/mcap: Fix scenario where schemaID equals 0 #991
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix crates.io publishing, crates.io link in README.md, and rust README link from README.md.
Partially addresses #542
**Public-Facing Changes** - Added `MCAPRandomAccessReader` class with log time ordered reading - Renamed library to `import MCAP` rather than `import mcap`, to follow more common Swift conventions - Added more documentation **Description** Adapted from TypeScript implementation. Uses the `Heap` class from https://github.com/apple/swift-collections — unfortunately it hasn't been released so I added a dependency on the current main commit.
**Public-Facing Changes** None **Description** Hoping this might help fix flaky CI.
**Public-Facing Changes** Bump C++ library version to 0.3.0
**Public-Facing Changes** Renamed variable `MCAP0_MAGIC` to `mcapMagic`. **Description** Follows guidance from https://www.swift.org/documentation/api-design-guidelines/ and https://google.github.io/swift/#global-constants.
This is an API-breaking change to rename all "Mcap0*" classes to "Mcap*" by changing the folder structure, file names, class names, and constant names.
* CLI: Add metadata support Adds metadata counts to mcap info output, and adds an mcap list metadata subcommand. * Standardize CLI table formatting function
**Public-Facing Changes** All writers now can compute data_section_crc and include it in the DataEnd record. C++: separated the writer options for chunk, attachment, data, and summary CRCs. **Description** Conformance tests also updated to ensure correct data_section_crc. Co-authored-by: Jacob Bandes-Storch <[email protected]>
Adds support for adding and getting metadata and attachments from an
existing mcap file. To add an attachment to a file,
mcap add attachment demo.mcap -f Makefile
To get an attachment out of the file,
mcap get attachment demo.mcap -n Makefile -o attachment.txt
To add metadata to a file,
mcap add metadata demo.mcap -k foo=bar -k bar=baz -n "my metadata"
To get metadata out of the file,
mcap get metadata demo.mcap -n "my metadata"
{
"bar": "baz",
"foo": "bar"
}
Also fixes a bug in the list attachments subcommand. Previously this was
listing chunks.
**Public-Facing Changes** Added command `mcap recover` for recovering data from truncated MCAP files. Added command `mcap compress` for changing the compression in an MCAP file. **Description** Both new commands share core implementation with `mcap filter`, with different implied options. Resolves #481 Resolves #446
**Public-Facing Changes** - Upstreams [Anduril's Rust library](https://github.com/anduril/mcap-rs), **Description** Adds a more fully-featured Rust library that supports indexed reading, CRC validation, record writing, chunking, and automatic summary writing. **TODOs** - Spelling (#618) - We probably want to make `serde` an optional dependency that we only pull in for the conformance reader. (I can't imagine users wanting to serialize random chunks of an MCAP file to JSON/CBOR/Bincode/etc.) - The round-trip test (`tests/round_trip.rs`) checks the message indexes by individually seeking each message from its respective chunk. This is... slow. Should we axe that part of the test to avoid bogging down CI?
**Public-Facing Changes** Added social preview cards to docs pages. Cards are autogenerated by mkdocs-material.
**Public-Facing Changes** None **Description** Made capitalization and casing more consistent in CLI tool and some other libraries' help/error messages
**Public-Facing Changes** None **Description** cc @foxglove/mcap-cli-maintainers on formula bump PRs.
**Public-Facing Changes** None **Description** Fixed an issue with the light color scheme
This skips v1.0.2 - that tag was pushed but this file wasn't updated, so the tag is wrong.
Previously this parameter did not function. Not sure if it never functioned or if we lost the support at some point.
### Public-Facing Changes None ### Description Update Homebrew formula path which changed in Homebrew/homebrew-core#139592. Relates to FG-4760
### Public-Facing Changes <!-- describe any changes to the public interface or APIs, or write "None" --> None ### Description <!-- describe what has changed, and motivation behind those changes --> - remove unused include - use explicit type conversion - ignore C4267 and C4244 for 3rd_party protobuf generate codes - prefer constexpr <!-- Link relevant Github issues. Use `Fixes #1234` to auto-close the issue after merging. -->
### Public-Facing Changes Swift: data is now properly sent to the writer each time a chunk is closed. ### Description
### Public-Facing Changes mcap-ros1-support: Add missing pyyaml dependency ### Description Fixes #955
### Public-Facing Changes - Revise docs for CLI to include correct release download link
### Public-Facing Changes Fix ROS 2 message equality check ### Description Use a custom comparison function that compares messages by their `__slots__` fields. Fixes #959 Resolves FG-4775
### Public-Facing Changes - Add Apex AI logos <img width="500" alt="Screenshot 2023-09-01 at 3 05 57 PM" src="https://github.com/foxglove/mcap/assets/6993359/25bc25cd-d9a7-438f-b06a-9a9d198d9bdd"> <img width="500" alt="Screenshot 2023-09-01 at 3 06 01 PM" src="https://github.com/foxglove/mcap/assets/6993359/9edfada8-4335-4e6c-95a2-7aaef9c2f6f8">
This aligns the spacing in the upper part of the "mcap info" output.
### Public-Facing Changes bugfix: Multiple iterators created from LinearMessageView::begin() will compare to `true`. ### Description <!-- describe what has changed, and motivation behind those changes --> <!-- Link relevant Github issues. Use `Fixes #1234` to auto-close the issue after merging. -->
Adds support for bringing custom compressors and decompressors to the go lexer and writer. For the writer, a ResettableWriteCloser is accepted. For the reader, a map of compression format to ResettableReader is accepted. If the reader implements io.Closer we'll call that on file close.
…#972) Bumps [mislav/bump-homebrew-formula-action](https://github.com/mislav/bump-homebrew-formula-action) from 2.2 to 2.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/mislav/bump-homebrew-formula-action/releases">mislav/bump-homebrew-formula-action's releases</a>.</em></p> <blockquote> <h2>bump-homebrew-formula 2.3</h2> <h2>What's Changed</h2> <ul> <li>Fix formula path after sharding of homebrew-core by <a href="https://github.com/williammartin"><code>@williammartin</code></a> in <a href="https://redirect.github.com/mislav/bump-homebrew-formula-action/pull/59">mislav/bump-homebrew-formula-action#59</a></li> <li>(docs): fix if condition in example by <a href="https://github.com/christian-bromann"><code>@christian-bromann</code></a> in <a href="https://redirect.github.com/mislav/bump-homebrew-formula-action/pull/54">mislav/bump-homebrew-formula-action#54</a></li> <li>(docs): use environment files instead of set-output by <a href="https://github.com/kyu08"><code>@kyu08</code></a> in <a href="https://redirect.github.com/mislav/bump-homebrew-formula-action/pull/57">mislav/bump-homebrew-formula-action#57</a></li> <li>Bump word-wrap from 1.2.3 to 1.2.4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/mislav/bump-homebrew-formula-action/pull/55">mislav/bump-homebrew-formula-action#55</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/christian-bromann"><code>@christian-bromann</code></a> made their first contribution in <a href="https://redirect.github.com/mislav/bump-homebrew-formula-action/pull/54">mislav/bump-homebrew-formula-action#54</a></li> <li><a href="https://github.com/kyu08"><code>@kyu08</code></a> made their first contribution in <a href="https://redirect.github.com/mislav/bump-homebrew-formula-action/pull/57">mislav/bump-homebrew-formula-action#57</a></li> <li><a href="https://github.com/williammartin"><code>@williammartin</code></a> made their first contribution in <a href="https://redirect.github.com/mislav/bump-homebrew-formula-action/pull/59">mislav/bump-homebrew-formula-action#59</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/mislav/bump-homebrew-formula-action/compare/v2.2...v2.3">https://github.com/mislav/bump-homebrew-formula-action/compare/v2.2...v2.3</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/mislav/bump-homebrew-formula-action/commit/d9e38dda029a3815f1b174c39b50f41e9587b4f6"><code>d9e38dd</code></a> lib</li> <li><a href="https://github.com/mislav/bump-homebrew-formula-action/commit/e52ec5927f540b0915935558eed2012dd16adb76"><code>e52ec59</code></a> Merge remote-tracking branch 'origin/main' into v2</li> <li><a href="https://github.com/mislav/bump-homebrew-formula-action/commit/98673ad870a3e0bb8d1f5a00f0fcd1d28afeed33"><code>98673ad</code></a> Fix formula path after sharding of homebrew-core (<a href="https://redirect.github.com/mislav/bump-homebrew-formula-action/issues/59">#59</a>)</li> <li><a href="https://github.com/mislav/bump-homebrew-formula-action/commit/341d7a93dd1dfb6eb0172a214d6327d3125967d5"><code>341d7a9</code></a> Merge pull request <a href="https://redirect.github.com/mislav/bump-homebrew-formula-action/issues/57">#57</a> from kyu08/use-env-files-instead-of-set-output</li> <li><a href="https://github.com/mislav/bump-homebrew-formula-action/commit/5840e8449eccfb204c41b4080c7364c887a14101"><code>5840e84</code></a> use environment files instead of set-output</li> <li><a href="https://github.com/mislav/bump-homebrew-formula-action/commit/a4ddef664a5cfef9d6352c5042c36db6e510a281"><code>a4ddef6</code></a> Merge pull request <a href="https://redirect.github.com/mislav/bump-homebrew-formula-action/issues/55">#55</a> from mislav/dependabot/npm_and_yarn/word-wrap-1.2.4</li> <li><a href="https://github.com/mislav/bump-homebrew-formula-action/commit/4771d809c531508384356359f87ae3455683e4af"><code>4771d80</code></a> Bump word-wrap from 1.2.3 to 1.2.4</li> <li><a href="https://github.com/mislav/bump-homebrew-formula-action/commit/8c81bc42521db2bcd75da43cd14c09f0e4d265ce"><code>8c81bc4</code></a> Merge pull request <a href="https://redirect.github.com/mislav/bump-homebrew-formula-action/issues/54">#54</a> from christian-bromann/cb-readme-fix</li> <li><a href="https://github.com/mislav/bump-homebrew-formula-action/commit/878ce377cf8af736e80a6ddbaf93ff2680b11687"><code>878ce37</code></a> (docs): fix if condition in example</li> <li><a href="https://github.com/mislav/bump-homebrew-formula-action/commit/78894b3c4ba3efb65f8c1dcb02486650eef312f5"><code>78894b3</code></a> Make a note of the "workflow" PAT scope in the setup docs</li> <li>Additional commits viewable in <a href="https://github.com/mislav/bump-homebrew-formula-action/compare/a1aa5acee0698beefeac8f69f2eb8a5f292bf8bb...d9e38dda029a3815f1b174c39b50f41e9587b4f6">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jacob Bandes-Storch <[email protected]>
### Public-Facing Changes Python: Detect invalid magic when instantiating `SeekingReader` ### Description Attempts to read the magic bytes when instantiating a `SeekingReader`, leading to an exception when the stream is not from a valid mcap file Resolves FG-4787
### Public-Facing Changes None ### Description This PR failed to run `docs-deploy` because it was authored by dependabot: #977 This copies similar logic that we use in `ci.yml` to exclude this job for dependabot. It's okay to skip because this job is not marked as a required check.
### Public-Facing Changes This adds a progress bar to show percentage completion when running `mcap convert ...`
### Public-Facing Changes None ### Description Fixed a spelling error in the CPP API readme.
### Public-Facing Changes CLI/merge: Avoid duplication of identical schemas ### Description - Removes some unused members of the McapMerger struct - Avoid duplication of identical schemas when merging mcap files. Schemas are considered identical if their md5 hash sum over the schema name, encoding and data is equal.
…#983) Bumps [mislav/bump-homebrew-formula-action](https://github.com/mislav/bump-homebrew-formula-action) from 2.3 to 3.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/mislav/bump-homebrew-formula-action/releases">mislav/bump-homebrew-formula-action's releases</a>.</em></p> <blockquote> <h2>bump-homebrew-formula-action 3.1</h2> <h2>What's Changed</h2> <ul> <li>Fix calculating checksum for resource at download URL by <a href="https://github.com/mislav"><code>@mislav</code></a> in <a href="https://redirect.github.com/mislav/bump-homebrew-formula-action/pull/77">mislav/bump-homebrew-formula-action#77</a></li> <li>Bump <code>@octokit/request-error</code> from 5.0.0 to 5.0.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/mislav/bump-homebrew-formula-action/pull/71">mislav/bump-homebrew-formula-action#71</a></li> <li>Bump <code>@octokit/core</code> from 5.0.0 to 5.0.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/mislav/bump-homebrew-formula-action/pull/75">mislav/bump-homebrew-formula-action#75</a></li> <li>Bump eslint from 8.49.0 to 8.50.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/mislav/bump-homebrew-formula-action/pull/74">mislav/bump-homebrew-formula-action#74</a></li> <li>Bump <code>@octokit/plugin-rest-endpoint-methods</code> from 9.0.0 to 10.0.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/mislav/bump-homebrew-formula-action/pull/72">mislav/bump-homebrew-formula-action#72</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/mislav/bump-homebrew-formula-action/compare/v3.0...v3.1">https://github.com/mislav/bump-homebrew-formula-action/compare/v3.0...v3.1</a></p> <h2>bump-homebrew-formula 3.0</h2> <h2>What's Changed</h2> <ul> <li>feat: bump to use node20 runtime by <a href="https://github.com/chenrui333"><code>@chenrui333</code></a> in <a href="https://redirect.github.com/mislav/bump-homebrew-formula-action/pull/61">mislav/bump-homebrew-formula-action#61</a></li> <li>Bump actions/checkout from 3 to 4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/mislav/bump-homebrew-formula-action/pull/63">mislav/bump-homebrew-formula-action#63</a></li> <li>Bump <code>@vercel/ncc</code> from 0.34.0 to 0.38.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/mislav/bump-homebrew-formula-action/pull/67">mislav/bump-homebrew-formula-action#67</a></li> <li>Bump <code>@actions/core</code> from 1.9.1 to 1.10.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/mislav/bump-homebrew-formula-action/pull/68">mislav/bump-homebrew-formula-action#68</a></li> <li>Bump <code>@octokit/core</code> from 3.5.1 to 5.0.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/mislav/bump-homebrew-formula-action/pull/65">mislav/bump-homebrew-formula-action#65</a></li> <li>Bump TypeScript from 4.7 to 5.2</li> <li>Bump <code>@typescript-eslint/eslint-plugin</code> from 5.43.0 to 6.7.2 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/mislav/bump-homebrew-formula-action/pull/66">mislav/bump-homebrew-formula-action#66</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/mislav/bump-homebrew-formula-action/compare/v2.4...v3.0">https://github.com/mislav/bump-homebrew-formula-action/compare/v2.4...v3.0</a></p> <h2>bump-homebrew-formula 2.4</h2> <h2>What's Changed</h2> <ul> <li>chore: use <code>/archive/refs/tags/${tagName}.tar.gz</code> rather than <code>/archive/${tagName}.tar.gz</code> by <a href="https://github.com/chenrui333"><code>@chenrui333</code></a> in <a href="https://redirect.github.com/mislav/bump-homebrew-formula-action/pull/53">mislav/bump-homebrew-formula-action#53</a></li> <li>Fix extracting version tags from GitHub download URLs by <a href="https://github.com/mislav"><code>@mislav</code></a> in <a href="https://redirect.github.com/mislav/bump-homebrew-formula-action/pull/62">mislav/bump-homebrew-formula-action#62</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/mislav/bump-homebrew-formula-action/compare/v2.3...v2.4">https://github.com/mislav/bump-homebrew-formula-action/compare/v2.3...v2.4</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/mislav/bump-homebrew-formula-action/commit/b3327118b2153c82da63fd9cbf58942146ee99f0"><code>b332711</code></a> lib</li> <li><a href="https://github.com/mislav/bump-homebrew-formula-action/commit/d1d8ac114ee8cd778de7f03107bcdfeb369e4e7b"><code>d1d8ac1</code></a> Merge remote-tracking branch 'origin/main' into v3</li> <li><a href="https://github.com/mislav/bump-homebrew-formula-action/commit/cf2d00157fd1b58ff3e9072843ffa0e3b0b4e9c8"><code>cf2d001</code></a> Fix calculating checksum for resource at download URL (<a href="https://redirect.github.com/mislav/bump-homebrew-formula-action/issues/77">#77</a>)</li> <li><a href="https://github.com/mislav/bump-homebrew-formula-action/commit/2bcfdc9312b916b0553579dde47e14140910898c"><code>2bcfdc9</code></a> Merge pull request <a href="https://redirect.github.com/mislav/bump-homebrew-formula-action/issues/72">#72</a> from mislav/dependabot/npm_and_yarn/octokit/plugin-res...</li> <li><a href="https://github.com/mislav/bump-homebrew-formula-action/commit/5678601dcb63610ff9ec7c025adc88fb93927d06"><code>5678601</code></a> Merge pull request <a href="https://redirect.github.com/mislav/bump-homebrew-formula-action/issues/74">#74</a> from mislav/dependabot/npm_and_yarn/eslint-8.50.0</li> <li><a href="https://github.com/mislav/bump-homebrew-formula-action/commit/addc60eb439210e1a096f830ff141c491d8f3321"><code>addc60e</code></a> Bump <code>@octokit/plugin-rest-endpoint-methods</code> from 9.0.0 to 10.0.0</li> <li><a href="https://github.com/mislav/bump-homebrew-formula-action/commit/44b3287225266352865d1345214f8445295b7a1d"><code>44b3287</code></a> Merge pull request <a href="https://redirect.github.com/mislav/bump-homebrew-formula-action/issues/75">#75</a> from mislav/dependabot/npm_and_yarn/octokit/core-5.0.1</li> <li><a href="https://github.com/mislav/bump-homebrew-formula-action/commit/fda81994d7488a62ef4c20a414e74e0a7c3f1edb"><code>fda8199</code></a> Merge pull request <a href="https://redirect.github.com/mislav/bump-homebrew-formula-action/issues/71">#71</a> from mislav/dependabot/npm_and_yarn/octokit/request-er...</li> <li><a href="https://github.com/mislav/bump-homebrew-formula-action/commit/2fd87fd7ea7022484241157fbfeee306dedac142"><code>2fd87fd</code></a> Bump <code>@octokit/core</code> from 5.0.0 to 5.0.1</li> <li><a href="https://github.com/mislav/bump-homebrew-formula-action/commit/0c2093084576429611bbaccb4d6e09725b0b145e"><code>0c20930</code></a> Bump eslint from 8.49.0 to 8.50.0</li> <li>Additional commits viewable in <a href="https://github.com/mislav/bump-homebrew-formula-action/compare/d9e38dda029a3815f1b174c39b50f41e9587b4f6...b3327118b2153c82da63fd9cbf58942146ee99f0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
### Description This lints the mcap cli
### Public-Facing Changes None ### Description Example code generates negative nanosecond values in the timestamp. Before:  After: 
### Public-Facing Changes Updates the rust library to use binrw v0.12.0. ### Description Updates the rust library to use binrw v0.12.0, which is compatible with the latest nightly compiler. This is unfortunately necessary because docs.rs builds docs using a nightly compiler that we don't control, and without it our docs don't build. ### Testing - [x] built and tested using nightly and stable
…wrong (#961) ### Public-Facing Changes There should be no changes in public API caused by this change. ### Description `read_record_from_slice` was checking that buffer size is bigger than 5 but was trying to read a `u8` and `u64` which are in total 9 bytes. This was causing panics when reading malformed mcap files or otherwise malformed streams. I added some simple tests as well but they aren't very robust (I don't check parsing of records).
### Public-Facing Changes
Use Python 3.8 for CI builds
### Description
Ensures that Python3.8 is used for CI. This was not the case so far as
`pipenv` was "resetting" the python version:
```
make lint
shell: /usr/bin/bash -e {0}
env:
pythonLocation: /opt/hostedtoolcache/Python/3.7.17/x64
PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.7.17/x64/lib/pkgconfig
Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.7.17/x64
Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.7.17/x64
Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.7.17/x64
LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.7.17/x64/lib
SETUPTOOLS_ENABLE_FEATURES="legacy-editable" pipenv install --dev --deploy
Creating a virtualenv for this project...
Pipfile: /home/runner/work/mcap/mcap/python/Pipfile
Using /usr/bin/python3 (3.10.12) to create virtualenv...
created virtual environment CPython3.10.12.final.0-64 in 636ms
```
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
mcap specification explains schema id that it must be not zero,and go cli has zero-check,The picture is as follows:
Description
schema's documnet of website is https://mcap.dev/spec;
so i add this judgment that schema can't not zero,but I'm not sure if this merging operation is reasonable；