Rust: Make RawMessage fields publicly accessible #934
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes foxglove#647, and maybe says something about how often that API is used. :P
mrkline
changed the title
|
@mrkline sorry about the delay - can you rebase this on latest main (so we can get updated CI) and we'll get it merged? |
|
Closing for inactivity. Happy to revisit if you have time to update to latest main. |
jtbandes
pushed a commit
that referenced
this pull request
Jun 24, 2024
### Changelog RawMessage fields are now public ### Docs None ### Description Currently the `RawMessageStream` is useless because the API does not expose the fields of the `RawMessage` struct. To solve this issue the fields of `RawMessages` are now marked as `pub`. ### References This PR is the same as #934
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #647, and maybe says something about how often that API is used. 😛