Rust: properly handle messages with log_time 0 #930
Conversation
|
Not sure how the tests are organized but is there an existing test for checking this behavior? Or is this code tested with the conformance tests? |
| @@ -7,7 +7,7 @@ categories = [ "science::robotics", "compression" ] | |||
| repository = "https://github.com/foxglove/mcap" | |||
| documentation = "https://docs.rs/mcap" | |||
| readme = "README.md" | |||
| version = "0.7.0" | |||
| version = "0.7.1" | |||
There was a problem hiding this comment.
Will we need to do anything to release this version to crates?
There was a problem hiding this comment.
The only previous instance of a "release" I've found is this tag: https://github.com/foxglove/mcap/releases/tag/releases%2Frust%2Fv0.6.0
There was a problem hiding this comment.
@james-rms is the owner of the crate (see https://crates.io/crates/mcap) so he'll have to push an update with cargo publish unless someone has his credentials sitting around. 😛
|
The existing unit tests should verify that file contents for the test outputs haven't changed (see https://github.com/foxglove/mcap/tree/main/rust/tests/data). A specific test that confirms #924 is gone wouldn't be a bad idea; I can add one later tonight. |
|
Test added. Looks like there's some spurious failure about an API token in the |
Update the Writer tracking of message bounds to include
log_time0 as a valid time for bounds.Additionally removes duplicated stats tracking data in the Chunk and overall MCAP writer.
Fix #924