-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python: specify packages to install for each module #1246
python: specify packages to install for each module #1246
Conversation
cc644ca
to
6b03885
Compare
6b03885
to
84d8451
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the docs:
Automatic discovery will only be enabled if you don’t provide any configuration for
packages
andpy_modules
. If at least one of them is explicitly set, automatic discovery will not take place.
And, during automatic discovery, tests
is part of FlatLayoutPackageFinder.DEFAULT_EXCLUDE
and FlatLayoutModuleFinder.DEFAULT_EXCLUDE
.
So if I'm understanding all of that correctly, it might suffice to simply delete these config lines and let the flat-layout/adhoc discovery take place, and tests will be automatically excluded.
It sounds like this is a different codepath from find:
, which is documented under custom discovery.
All that said, I think the change you made here is also good because being explicit is safe and straightforward.
Changelog
mcap
,mcap-protobuf-support
,mcap-ros1-support
,mcap-ros2-support
now only install their main packages rather than all packages including tests.__init__
methods with no arguments implementing this guide: https://mypy.readthedocs.io/en/stable/class_basics.html#annotating-init-methodsDocs
Description
Rely on setuptools' auto-discovery mechanism to find the python packages we're trying to expose while auto-excluding
tests
, which were previously being included into users' install directories.Testing
python -m zipfile --list mcap_protobuf_support-0.5.2-py3-none-any.whl
to ensure that the whole library content is present and no test directories are present.