Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EOF reads on streams with an unknown size #33

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

Schamper
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #33 (7195b16) into main (3b865b7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   85.00%   85.01%   +0.01%     
==========================================
  Files          16       16              
  Lines        1107     1108       +1     
==========================================
+ Hits          941      942       +1     
  Misses        166      166              
Flag Coverage Δ
unittests 85.01% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
dissect/util/stream.py 91.19% <100.00%> (+0.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@Poeloe Poeloe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Schamper Schamper merged commit 6704c0d into main Oct 18, 2023
30 checks passed
@Schamper Schamper deleted the fix-read-eof-unknown-size branch October 18, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants