Support st_blksize and st_blocks on JFFS2 #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #912 +/- ##
==========================================
+ Coverage 76.65% 76.68% +0.03%
==========================================
Files 316 316
Lines 27101 27103 +2
==========================================
+ Hits 20774 20784 +10
+ Misses 6327 6319 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Schamper
requested changes
Oct 17, 2024
| # JFFS2 block size is a function of the "erase size" of the underlying flash device. | ||
| # Linux stat reports the default block size, which is defined as 4k in libc. | ||
| st_info.st_blksize = 4096 | ||
| st_info.st_blocks = (node.isize + 511) // 512 if self.is_file() else 0 |
There was a problem hiding this comment.
Can you add a unit test for a directory entry?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The block size is a function of the "erase size" of the underlying flash device.
Linux stat reports the default block size, which is defined as 4k in libc.
Also tried to implement missing nlink functionality as a bonus, but it exceeded the story budget.
Will create issue for it after the weekend.
Closes #819