Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistency of target.ips output #870

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

JSCU-CNI
Copy link
Contributor

@JSCU-CNI JSCU-CNI commented Oct 1, 2024

Fixes #877.

@JSCU-CNI JSCU-CNI changed the title Fix consistency of ip address output Fix inconsistency of target.ips output Oct 1, 2024
@EinatFox
Copy link

EinatFox commented Oct 2, 2024

Hi @JSCU-CNI , please open an issue and attache this PR so we can schedule a review into our sprints.

dissect/target/plugins/os/unix/bsd/osx/_os.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/_os.py Outdated Show resolved Hide resolved
dissect/target/tools/info.py Outdated Show resolved Hide resolved
Copy link
Member

@Schamper Schamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the broken suggestion 😄 would it be possible to make a regression test too?

dissect/target/plugins/os/unix/linux/_os.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.41%. Comparing base (d0eba16) to head (65cc4ce).

Files with missing lines Patch % Lines
dissect/target/plugins/os/windows/_os.py 0.00% 1 Missing ⚠️
dissect/target/tools/info.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #870      +/-   ##
==========================================
- Coverage   76.41%   76.41%   -0.01%     
==========================================
  Files         314      314              
  Lines       26918    26914       -4     
==========================================
- Hits        20569    20565       -4     
  Misses       6349     6349              
Flag Coverage Δ
unittests 76.41% <71.42%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JSCU-CNI
Copy link
Contributor Author

JSCU-CNI commented Oct 7, 2024

Couldn't figure out how to properly modify a VirtualHive in a way the RegistryPlugin registers multiple ControlSets. Perhaps you know of a better way @Schamper?

@JSCU-CNI
Copy link
Contributor Author

JSCU-CNI commented Oct 8, 2024

We can further simplify the general network plugin when fox-it/flow.record#148 is merged.

@JSCU-CNI
Copy link
Contributor Author

This is now ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output of target.ips is inconsistent
3 participants