Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small log improvements #857

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

JSCU-CNI
Copy link
Contributor

@JSCU-CNI JSCU-CNI commented Sep 19, 2024

This PR addresses two small issues:

  • The hash record modifier could generate a lot of warnings when combining the walkfs plugin with --hash as a lot of files can be broken. this log is now demoted to INFO for FileNotFoundErrors as that exception is not really interesting in those instances.
  • When entering a child target using --children or target-shell's enter the path of said child was appended to the locations of where to look for targetcfg files. That obviously does not work as that path is virtual inside the main target. This is now fixed.

Fixes #880 and fixes #881.

@EinatFox
Copy link

EinatFox commented Oct 2, 2024

Hi @JSCU-CNI , please open an issue and attache this PR so we can schedule a review into our sprints.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.70%. Comparing base (ebd38fe) to head (fead052).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #857   +/-   ##
=======================================
  Coverage   76.70%   76.70%           
=======================================
  Files         315      315           
  Lines       27033    27039    +6     
=======================================
+ Hits        20735    20741    +6     
  Misses       6298     6298           
Flag Coverage Δ
unittests 76.70% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants