Fix issue with pathless config items #785
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #785 +/- ##
==========================================
- Coverage 75.56% 75.55% -0.01%
==========================================
Files 299 299
Lines 25782 25784 +2
==========================================
+ Hits 19481 19482 +1
- Misses 6301 6302 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Miauwkeru
reviewed
Aug 2, 2024
cecinestpasunepipe
force-pushed
the
fix/etc_path
branch
from
027237a
to
deb58c5
Compare
Miauwkeru
requested changes
Aug 5, 2024
|
alternatively you can just pass |
Miauwkeru
requested changes
Aug 5, 2024
Schamper
requested changes
Aug 12, 2024
Co-authored-by: Erik Schamper <[email protected]>
Co-authored-by: Erik Schamper <[email protected]>
Miauwkeru
requested changes
Aug 30, 2024
|
|
||
| if isinstance(config_object, ConfigurationEntry): | ||
| path = Path(entry) / Path(item) | ||
| yield from self._sub(config_object, path, orig_path=path, pattern=pattern) |
There was a problem hiding this comment.
orig_path will not contain the root. aka, /etc. I think it might be a good idea to add that to it.
Comment on lines
73
to
+76
| config_object = self.get(str(Path(entry) / Path(item))) | ||
| yield from self._sub(config_object, Path(entry) / Path(item), pattern) | ||
|
|
||
| if isinstance(config_object, ConfigurationEntry): | ||
| path = Path(entry) / Path(item) |
There was a problem hiding this comment.
path = Path(entry) / item
config_object = self.get(str(path))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.