Add output_def to PluginFunction #759
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks - this is also already covered by my own refactor of the plugin system internals, so don't be sad if this PR will be rejected 😉. I've been sick for a few days but I'm trying to get that wrapped up as quick as I can. |
|
Closing this in favor of #763. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
output_defattribute to thePluginFunctiondataclass and populates it during runtime infind_plugin_functions. Theoutput_defattribute should be filled withRecordDescriptorinstances when theoutput_typeisrecord. For further assumptions seetest_find_plugin_function_record_def.We use this attribute to discover all possible output field types of
target-queryin our (to be published) dissect-elastic tool. This tool facilitates in generating valid Elasticsearch field mapping objects.