Add support for deleted files in deleted RecycleBin directories #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schamper
requested changes
Jul 10, 2024
| @@ -125,6 +129,44 @@ def read_bin_file(self, bin_path: TargetPath) -> RecycleBinRecord: | |||
| _user=user, | |||
| ) | |||
|
|
|||
| def read_recycle_deleted_folder(self, folder_path: TargetPath) -> RecycleBinRecord: | |||
There was a problem hiding this comment.
Suggested change
| def read_recycle_deleted_folder(self, folder_path: TargetPath) -> RecycleBinRecord: | |
| def read_recycle_deleted_folder(self, path: TargetPath) -> RecycleBinRecord: |
And rename accordingly.
|
|
||
| user_details = self.target.user_details.find(sid=sid) | ||
| user = user_details.user if user_details else None | ||
| for parent_path, _, childs in folder_path.walk(): |
There was a problem hiding this comment.
Maybe rglob works better for you? Then you don't have to do the nasty path construction at line 156 and 157.
Co-authored-by: Erik Schamper <[email protected]>
Co-authored-by: Erik Schamper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for deleted files in deleted RecycleBin directories
Also made some minor changes to variable names to make it more clear what function does what.
Resolves #638