Add plugin to parse recentlyused.xbel files from Linux desktops #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because this year will be the year of the Linux desktop.
Miauwkeru
requested changes
Aug 9, 2024
| from dissect.target.plugin import Plugin, export | ||
|
|
||
| RecentlyUsedRecord = TargetRecordDescriptor( | ||
| "unix/linux/recentlyused", |
There was a problem hiding this comment.
Suggested change
| "unix/linux/recentlyused", | |
| "unix/linux/recently_used", |
| ) | ||
|
|
||
| RecentlyUsedIconRecord = TargetRecordDescriptor( | ||
| "unix/linux/recentlyusedicon", |
There was a problem hiding this comment.
Suggested change
| "unix/linux/recentlyusedicon", | |
| "unix/linux/recently_used_icon", |
| ) | ||
|
|
||
| RecentlyUsedApplicationRecord = TargetRecordDescriptor( | ||
| "unix/linux/recentlyusedapplication", |
There was a problem hiding this comment.
Suggested change
| "unix/linux/recentlyusedapplication", | |
| "unix/linux/recently_used_application", |
| href=icon.get("href"), | ||
| name=icon.get("name"), | ||
| ) | ||
| yield GroupedRecord("unix/linux/recentlyused/grouped", [cur, iconrecord]) |
There was a problem hiding this comment.
Suggested change
| yield GroupedRecord("unix/linux/recentlyused/grouped", [cur, iconrecord]) | |
| yield GroupedRecord("unix/linux/recently_used/grouped", [cur, iconrecord]) |
| exec=app.get("exec"), | ||
| count=app.get("count"), | ||
| ) | ||
| yield GroupedRecord("unix/linux/recentlyused/grouped", [cur, apprecord]) |
There was a problem hiding this comment.
Suggested change
| yield GroupedRecord("unix/linux/recentlyused/grouped", [cur, apprecord]) | |
| yield GroupedRecord("unix/linux/recently_used/grouped", [cur, apprecord]) |
| """Parse recently-used.xbel files on Linux Desktops.""" | ||
|
|
||
| for user, xbel_file in self.users_files: | ||
| for record in parse_recentlyused_xbel(user.name, xbel_file): |
There was a problem hiding this comment.
Suggested change
| for record in parse_recentlyused_xbel(user.name, xbel_file): | |
| for record in parse_recently_used_xbel(user.name, xbel_file): |
| fs_unix.map_file("/home/user/.local/share/recently-used.xbel", data_file) | ||
| target_unix_users.add_plugin(RecentlyUsedPlugin) | ||
|
|
||
| results = list(target_unix_users.recentlyused()) |
There was a problem hiding this comment.
Suggested change
| results = list(target_unix_users.recentlyused()) | |
| results = list(target_unix_users.recently_used()) |
| visited=parse_ts(b.get("visited")), | ||
| mimetype=mimetype, | ||
| groups=group_list, | ||
| private=private, |
There was a problem hiding this comment.
Suggested change
| private=private, | |
| private=private, | |
| _target=self.target, |
The TargetRecordDescriptor provides a field named _target this will cause the hostname and domain fields to get filled.
That being said, I don't think RecentlyUsedIconRecord and RecentlyUsedApplicationRecord need to be a TargetRecordDescriptor as it would only provide redundant information
| private = private_entries is not None and len(private_entries) > 0 | ||
|
|
||
| cur = RecentlyUsedRecord( | ||
| ts=parse_ts(b.get("visited")), |
There was a problem hiding this comment.
Are the timestamp fields always available? cause if they are None the plugin will crash
|
|
||
| # There should be at most one "private" tag, but accept multiple | ||
| private_entries = b.findall("./info/metadata/bookmark:private", ns) | ||
| private = private_entries is not None and len(private_entries) > 0 |
There was a problem hiding this comment.
I believe b.findall always returns a list, so the none check here is redundant.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because this year will be the year of the Linux desktop.