Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copyable command for deployment #2727

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

kkawula
Copy link
Collaborator

@kkawula kkawula commented Nov 28, 2024

Closes #2667

Introduced changes

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

}

if add_profile.is_some() {
let config = CastConfig {
url: create.rpc.url.clone().unwrap_or_default(),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It didn't work in case where url is provided from profile

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rare but possible

@kkawula kkawula marked this pull request as ready for review November 28, 2024 13:28
@kkawula kkawula marked this pull request as draft November 28, 2024 14:42
@kkawula kkawula marked this pull request as ready for review December 2, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sncast account create should show copyable command for deployment
2 participants