Extend plugin diagnostics with warnings #2702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nemezjusz
requested review from
cptartur,
ddoktorski,
kkawula and
franciszekjob
as code owners
Nemezjusz
force-pushed
the
extending_warns
branch
from
f332923
to
d34069f
Compare
ddoktorski
reviewed
Nov 29, 2024
There was a problem hiding this comment.
Thank you for the contribution @Nemezjusz
Could you rename the title of the PR to something like Extend plugin diagnostics with warnings. I've left only one comment to the changelog, other than that it looks good to me :))
ddoktorski
reviewed
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2358
Hi, I think I finished this issue, but let me know if I should change anything!