Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cheatcode docs update #2577

Merged
merged 3 commits into from
Oct 15, 2024
Merged

cheatcode docs update #2577

merged 3 commits into from
Oct 15, 2024

Conversation

0xGreed
Copy link
Contributor

@0xGreed 0xGreed commented Oct 12, 2024

Closes #

Introduced changes

  • docs more accurate

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

the `stop_cheat_block_number_global` cheatcode acts at a global level and does not require an argument
The `stop_cheat_block_timestamp_global` cheatcode does not require an argument as it acts at a global level
@franciszekjob
Copy link
Collaborator

Hey @0xGreed
Indeed stop_cheat_block_number_global and stop_cheat_block_timestamp_global don't have target param - good catch 👍 .

I see that other global stop functions have the same issue (e.g. stop_cheat_block_number_global and stop_cheat_transaction_version_global. Could you please address them as well 🙏 ?

@0xGreed
Copy link
Contributor Author

0xGreed commented Oct 15, 2024

Hey, sent another pull request for the additional cheatcodes left : #2579

@kkawula kkawula added this pull request to the merge queue Oct 15, 2024
@kkawula kkawula removed this pull request from the merge queue due to a manual request Oct 15, 2024
@franciszekjob franciszekjob added this pull request to the merge queue Oct 15, 2024
Merged via the queue into foundry-rs:master with commit 7778925 Oct 15, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants