Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp account import #2565

Merged
merged 34 commits into from
Oct 14, 2024
Merged

Revamp account import #2565

merged 34 commits into from
Oct 14, 2024

Conversation

franciszekjob
Copy link
Collaborator

@franciszekjob franciszekjob commented Oct 7, 2024 •
edited
Loading

Closes #2218

Introduced changes

  • Update account add to account import
  • Remove --public-key flag
  • Add address computation and validation based on provided salt, class hash, private key and account type
  • Allow to pass private key in interactive mode when neither --private-key nor --private-key-file is passed
  • Add "Importing Accounts" guide section

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@franciszekjob franciszekjob changed the title Revamp importing account Revamp account import Oct 7, 2024
@franciszekjob franciszekjob marked this pull request as ready for review October 8, 2024 12:42
cptartur
cptartur requested changes Oct 11, 2024
View reviewed changes
crates/sncast/src/starknet_commands/account/import.rs Outdated Show resolved Hide resolved
crates/sncast/src/starknet_commands/account/import.rs Outdated Show resolved Hide resolved
crates/sncast/src/starknet_commands/account/import.rs Outdated Show resolved Hide resolved
crates/sncast/src/starknet_commands/account/import.rs Outdated Show resolved Hide resolved
crates/sncast/src/starknet_commands/account/import.rs Show resolved Hide resolved
docs/src/starknet/account-import-export.md Outdated Show resolved Hide resolved
docs/src/starknet/account-import-export.md Outdated Show resolved Hide resolved
docs/src/starknet/account-import-export.md Outdated Show resolved Hide resolved
docs/src/starknet/account-import-export.md Outdated Show resolved Hide resolved
docs/src/starknet/account.md Outdated Show resolved Hide resolved
@cptartur cptartur mentioned this pull request Oct 14, 2024
Merged
5 tasks
cptartur
cptartur requested changes Oct 14, 2024
View reviewed changes
crates/sncast/src/starknet_commands/account/import.rs Show resolved Hide resolved
docs/src/starknet/account-import.md Outdated Show resolved Hide resolved
docs/src/starknet/account-import.md Outdated Show resolved Hide resolved
@franciszekjob franciszekjob added this pull request to the merge queue Oct 14, 2024
Merged via the queue into master with commit 0e21418 Oct 14, 2024
24 checks passed
@franciszekjob franciszekjob deleted the franciszekjob/2218-account-import branch October 14, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cptartur cptartur cptartur approved these changes

@ksew1 ksew1 Awaiting requested review from ksew1

@integraledelebesgue integraledelebesgue Awaiting requested review from integraledelebesgue

@ddoktorski ddoktorski Awaiting requested review from ddoktorski ddoktorski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revamp account add procedure
2 participants
@franciszekjob @cptartur