Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored call, deploy and invoke command handlers #2546

Closed
wants to merge 1 commit into from
Closed

Refactored call, deploy and invoke command handlers #2546

wants to merge 1 commit into from

Conversation

integraledelebesgue
Copy link
Member

@integraledelebesgue integraledelebesgue commented Oct 1, 2024 •
edited
Loading

This was referenced Oct 1, 2024
Closed
Closed
Closed
@integraledelebesgue integraledelebesgue force-pushed the spr/master/13b07d29 branch 2 times, most recently from ea09480 to c5d5e25 Compare October 2, 2024 14:02
kkawula
kkawula reviewed Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@kkawula kkawula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we remove all shortcuts for commands?

@integraledelebesgue integraledelebesgue force-pushed the spr/master/fad6001c branch 2 times, most recently from 67f3995 to 8012988 Compare October 3, 2024 13:36
@integraledelebesgue integraledelebesgue force-pushed the spr/master/13b07d29 branch 2 times, most recently from 9ad9a56 to 54a328a Compare October 3, 2024 14:58
@integraledelebesgue
Copy link
Member Author

integraledelebesgue commented Oct 3, 2024 •
edited
Loading

Why do we remove all shortcuts for commands?

Nevermind, global flags have been fixed on master so I reverted my changes related to them here

@integraledelebesgue integraledelebesgue mentioned this pull request Oct 4, 2024
Merged
@integraledelebesgue integraledelebesgue force-pushed the spr/master/fad6001c branch 2 times, most recently from 8803dac to e485614 Compare October 4, 2024 19:08
@integraledelebesgue integraledelebesgue force-pushed the spr/master/13b07d29 branch 2 times, most recently from dcd604e to ca4045e Compare October 4, 2024 19:16
cptartur
cptartur approved these changes Oct 7, 2024
View reviewed changes
crates/sncast/src/starknet_commands/verify.rs Outdated Show resolved Hide resolved
@integraledelebesgue integraledelebesgue force-pushed the spr/master/13b07d29 branch 2 times, most recently from 5cb9686 to 94a29da Compare October 8, 2024 17:28
@integraledelebesgue integraledelebesgue force-pushed the spr/master/13b07d29 branch 3 times, most recently from 9026cb8 to c02c9c1 Compare October 11, 2024 11:33
@integraledelebesgue
Copy link
Member Author

✓ Commit merged in pull request #2555

github-merge-queue bot pushed a commit that referenced this pull request Oct 16, 2024
@integraledelebesgue
Introduced Data Transformer (#2555)
a2e3c7d 
**Stack**:
- #2555
- #2548
- #2547
- #2546
- #2545
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cptartur cptartur cptartur approved these changes

@ksew1 ksew1 Awaiting requested review from ksew1 ksew1 is a code owner

@ddoktorski ddoktorski Awaiting requested review from ddoktorski ddoktorski is a code owner

@kkawula kkawula Awaiting requested review from kkawula

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@integraledelebesgue @cptartur @kkawula