Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for output()?.status.success() when calling a binary where needed #1915

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Check for output()?.status.success() when calling a binary where needed #1915

merged 1 commit into from
Mar 22, 2024

Conversation

Draggu
Copy link
Contributor

@Draggu Draggu commented Mar 19, 2024

Closes #1866

Introduced changes

  • Check for output()?.status.success() when calling a binary where needed

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@Draggu Draggu requested review from a team as code owners March 19, 2024 12:04
@Draggu Draggu requested review from Arcticae, war-in, THenry14 and ddoktorski and removed request for a team March 19, 2024 12:04
Arcticae
Arcticae approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@Arcticae Arcticae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Draggu Draggu added this pull request to the merge queue Mar 22, 2024
Merged via the queue into master with commit 4e90fd6 Mar 22, 2024
13 checks passed
@Draggu Draggu deleted the output-check branch March 22, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arcticae Arcticae Arcticae approved these changes

@piotmag769 piotmag769 piotmag769 approved these changes

@war-in war-in Awaiting requested review from war-in war-in was automatically assigned from foundry-rs/starknet-foundry-forge

@THenry14 THenry14 Awaiting requested review from THenry14 THenry14 was automatically assigned from foundry-rs/starknet-foundry-cast

@ddoktorski ddoktorski Awaiting requested review from ddoktorski ddoktorski was automatically assigned from foundry-rs/starknet-foundry-cast

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check for output()?.status.success() when calling a binary where needed
3 participants
@Draggu @Arcticae @piotmag769