Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump used RPC to version 0.7.0 #1859

Merged
merged 12 commits into from
Mar 16, 2024
Merged

Bump used RPC to version 0.7.0 #1859

merged 12 commits into from
Mar 16, 2024

Conversation

Draggu
Copy link
Contributor

@Draggu Draggu commented Mar 11, 2024 •
edited
Loading

Closes #1857

Introduced changes

  • Bumped used RPC version to 0.7.0-rc2

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@Draggu Draggu requested a review from a team as a code owner March 11, 2024 13:14
@Draggu Draggu requested review from war-in, drknzz and Arcticae and removed request for a team March 11, 2024 13:14
@Draggu Draggu added the blocked label Mar 13, 2024
@Draggu
Copy link
Contributor Author

Draggu commented Mar 13, 2024

Blocked by #1851. Changes made in #1851 are required for this to pass.

@Draggu Draggu requested a review from a team as a code owner March 13, 2024 11:45
@Draggu Draggu requested review from THenry14 and DelevoXDG and removed request for a team March 13, 2024 11:45
ddoktorski
ddoktorski reviewed Mar 13, 2024
View reviewed changes
scripts/install_devnet.sh Outdated Show resolved Hide resolved
crates/sncast/tests/helpers/devnet.rs Show resolved Hide resolved
crates/forge/tests/data/forking/.gitignore Outdated Show resolved Hide resolved
@Draggu Draggu removed the blocked label Mar 13, 2024
drknzz
drknzz reviewed Mar 14, 2024
View reviewed changes
crates/cheatnet/tests/cheatcodes/prank.rs Show resolved Hide resolved
crates/sncast/tests/e2e/script/call.rs Show resolved Hide resolved
crates/sncast/tests/e2e/script/deploy.rs Outdated Show resolved Hide resolved
crates/sncast/tests/e2e/script/invoke.rs Outdated Show resolved Hide resolved
THenry14
THenry14 reviewed Mar 14, 2024
View reviewed changes
crates/sncast/tests/e2e/script/call.rs Show resolved Hide resolved
crates/sncast/tests/e2e/script/deploy.rs Outdated Show resolved Hide resolved
crates/shared/src/consts.rs Show resolved Hide resolved
crates/sncast/tests/e2e/script/deploy.rs Outdated Show resolved Hide resolved
@Draggu Draggu mentioned this pull request Mar 15, 2024
Closed
THenry14
THenry14 approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@THenry14 THenry14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, let's wait for an approval from someone from forge team before merge

piotmag769
piotmag769 approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@piotmag769 piotmag769 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, when will our nodes be updated to 0.7.0 so we can bump it? @THenry14

@Draggu Draggu added this pull request to the merge queue Mar 16, 2024
Merged via the queue into master with commit b458b75 Mar 16, 2024
13 checks passed
@Draggu Draggu deleted the bump-rpc branch March 16, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddoktorski ddoktorski ddoktorski left review comments

@drknzz drknzz drknzz left review comments

@THenry14 THenry14 THenry14 approved these changes

@piotmag769 piotmag769 piotmag769 approved these changes

@war-in war-in Awaiting requested review from war-in war-in was automatically assigned from foundry-rs/starknet-foundry-forge

@Arcticae Arcticae Awaiting requested review from Arcticae

@DelevoXDG DelevoXDG Awaiting requested review from DelevoXDG DelevoXDG was automatically assigned from foundry-rs/starknet-foundry-cast

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump used RPC to 0.7.0
5 participants
@Draggu @THenry14 @ddoktorski @piotmag769 @drknzz