Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp event mechanics #1889

Closed
Arcticae opened this issue Mar 15, 2024 · 0 comments · Fixed by #2251
Closed

Revamp event mechanics #1889

Arcticae opened this issue Mar 15, 2024 · 0 comments · Fixed by #2251
Assignees
@tomek0123456789
Labels
design-doc snforge
Milestone
`snforge_std` ref...

Comments

@Arcticae
Copy link
Contributor

Which components does the task require to be changed? (think hard pls)

snforge

Description

  1. We should implement a way of automatic writing the emitted events to the segment where the events are stored, instead of requiring the user to fetch the events manually (which is easy to forget).
  2. We should send the event to each spy that is elligible for receiving the spy (its group captures the address that the event is from)
@Arcticae Arcticae added this to the `snforge_std` refactor milestone Mar 15, 2024
@github-actions github-actions bot added the new label Mar 15, 2024
@Arcticae Arcticae mentioned this issue Mar 15, 2024
Closed
@Draggu Draggu mentioned this issue Mar 18, 2024
Closed
5 tasks
@Draggu Draggu self-assigned this Mar 18, 2024
@Arcticae Arcticae removed the new label May 8, 2024
@tomek0123456789 tomek0123456789 mentioned this issue Jun 24, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Jun 24, 2024
@tomek0123456789
Refactor event logic (#2251)
18f32ec 
<!-- Reference any GitHub issues resolved by this PR -->

Closes #1889 

## Introduced changes

<!-- A brief description of the changes -->

- revamp event logic

Original stack here:
- #2193 
- #2194 
- #2195
- #2224 

## Checklist

<!-- Make sure all of these are complete -->

- [ ] Linked relevant issue
- [ ] Updated relevant documentation
- [ ] Added relevant tests
- [ ] Performed self-review of the code
- [ ] Added changes to `CHANGELOG.md`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomek0123456789 tomek0123456789

Labels
design-doc snforge
Projects
Starknet foundry
Archived in project
Milestone
`snforge_std` refactor
Development

Successfully merging a pull request may close this issue.

Refactor event logic foundry-rs/starknet-foundry
4 participants
@tomek0123456789 @MaksymilianDemitraszek @Arcticae @Draggu