Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine events detection behaviour + backend #1837

Closed
piotmag769 opened this issue Mar 6, 2024 · 1 comment
Closed

Refine events detection behaviour + backend #1837

piotmag769 opened this issue Mar 6, 2024 · 1 comment
Labels
bug Something isn't working snforge

Comments

@piotmag769
Copy link
Member

Which components does the task require to be changed? (think hard pls)

snforge

Description

Currently we check if the event should be caught by any spy, if it should, we add it to detected events.
Then in fetch_events we consume the events that the spy should catch, deleting it from detected events vector.

This results in a weird coupling of logic and causes unintuitive behaviour when spying on the same contract with multiple spies.

We should instead keep a queue for each spy and push/pop events from it accordingly

@github-actions github-actions bot added the new label Mar 6, 2024
@Arcticae Arcticae added bug Something isn't working and removed new labels Mar 11, 2024
@Arcticae
Copy link
Contributor

Irrelevant because of #1889

@Arcticae Arcticae closed this as not planned Won't fix, can't repro, duplicate, stale Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working snforge
Projects
Archived in project
Development

No branches or pull requests

2 participants