-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for output()?.status.success()
when calling a binary where needed
#1866
Comments
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Mar 22, 2024
…ed (#1915) <!-- Reference any GitHub issues resolved by this PR --> Closes #1866 ## Introduced changes <!-- A brief description of the changes --> - Check for output()?.status.success() when calling a binary where needed ## Checklist <!-- Make sure all of these are complete --> - [x] Linked relevant issue - [x] Updated relevant documentation - [x] Added relevant tests - [x] Performed self-review of the code - [x] Added changes to `CHANGELOG.md`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Which components does the task require to be changed? (think hard pls)
snforge, sncast
Description
Rn e.g. when calling USC we don't check the status, we just do
output()?
. It will result in an error appearing in wrong place and misleading users. We also have some occurrences of it in our testsDidn't find any occurrences of it in sncast but it's worth checking it to, just look for
output()
in the codebase.The text was updated successfully, but these errors were encountered: