Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for output()?.status.success() when calling a binary where needed #1866

Closed
piotmag769 opened this issue Mar 12, 2024 · 0 comments · Fixed by #1915
Closed

Check for output()?.status.success() when calling a binary where needed #1866

piotmag769 opened this issue Mar 12, 2024 · 0 comments · Fixed by #1915
Assignees
@Draggu
Labels
bug Something isn't working snforge

Comments

@piotmag769
Copy link
Member

Which components does the task require to be changed? (think hard pls)

snforge, sncast

Description

Rn e.g. when calling USC we don't check the status, we just do output()?. It will result in an error appearing in wrong place and misleading users. We also have some occurrences of it in our tests

Didn't find any occurrences of it in sncast but it's worth checking it to, just look for output() in the codebase.
@piotmag769 piotmag769 added bug Something isn't working snforge labels Mar 12, 2024
@github-actions github-actions bot added the new label Mar 12, 2024
@Arcticae Arcticae removed the new label Mar 18, 2024
@Draggu Draggu self-assigned this Mar 19, 2024
@Draggu Draggu mentioned this issue Mar 19, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Mar 22, 2024
@Draggu
Check for output()?.status.success() when calling a binary where need…
4e90fd6 
…ed (#1915)

<!-- Reference any GitHub issues resolved by this PR -->

Closes #1866

## Introduced changes

<!-- A brief description of the changes -->

- Check for output()?.status.success() when calling a binary where
needed

## Checklist

<!-- Make sure all of these are complete -->

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests
- [x] Performed self-review of the code
- [x] Added changes to `CHANGELOG.md`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Draggu Draggu

Labels
bug Something isn't working snforge
Projects
Starknet foundry
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check for output()?.status.success() when calling a binary where needed foundry-rs/starknet-foundry
3 participants
@Arcticae @piotmag769 @Draggu