-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify device group read-only permission #772
base: main
Are you sure you want to change the base?
Clarify device group read-only permission #772
Conversation
The documentation was reworded. The changes should help clarify that members with read-only permission can still view other groups and devices. QA: Viewed rendered html, edited with linter plugin. Ran linkcheck. This commit addresses ticket FFTK-3602, "clarify device group read permission details" Signed-off-by: Katrina Prosise <[email protected]>
Docs for cb06851 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2798/docs/artifacts/html/index.html |
Members of the "read-only-users" team have read-only access to all factory resources with one exception—device groups and devices. | ||
They can see only the ``test-lab-devices`` group and devices included into it. | ||
Members of the "read-only-users" team have read-only access to all factory resources. | ||
They can only *see* the ``test-lab-devices`` group and devices included into it, they can not make any modifications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel this is still a bit misleading. They can see all devices, but can only make modifications to devices in this device group. With the current sentence, they can still think they should be able to only see the devices in this device group.
Maybe under https://ci.foundries.io/projects/fio-docs/builds/2798/docs/artifacts/html/user-guide/account-management/team-based-access.html#team-based-access-to-device-groups we can do add a note or something saying that device and CI/targets view are available for all users. |
ci/targets can be blocked to a user in a team that's not given access to ci/targets. But a user in no team can view them |
My mind is a bit jumbled now about what exactly we are trying to say. I will try to parse this all again soon. |
The documentation was reworded. The changes should help clarify that members with read-only permission can still view other groups and devices.
QA: Viewed rendered html, edited with linter plugin. Ran linkcheck.
This commit addresses ticket FFTK-3602, "clarify device group read permission details"
PR Template and Checklist
Please complete as much as possible to speed up the reviewing process.
Readiness and adding reviewers as appropriate is required.
All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.
Readiness
Overview
Addresses point of confusion for customer
Checklist
make linkcheck
.-s, --signoff
).-S, --gpg-sign
).Comments
Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.