Fix _has_class to avoid confusion with partial matches

foundation · Oct 11, 2016 · 94df4b3 · 94df4b3
1 parent 002a295
commit 94df4b3
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/lib/component_factory.rb b/lib/component_factory.rb
@@ -18,7 +18,7 @@ def _pass_through_attributes(elem)
  end
 
  def _has_class(elem, klass)
- (elem.attr('class') || '').include?(klass)
+ elem.attr('class') =~ /(^|\s)#{klass}($|\s)/
  end
 
  def _combine_classes(elem, extra_classes)

diff --git a/spec/cases/button/with_tricky_class.inky b/spec/cases/button/with_tricky_class.inky
@@ -1,5 +1,19 @@
-<!-- pending -->
-
 <button href="http://example.com" class="noexpand">
  A label
 </button>
+
+<button href="http://example.com" class="expand-niet">
+ A label
+</button>
+
+<button href="http://example.com" class="expand foo">
+ A label
+</button>
+
+<button href="http://example.com" class="foo expand">
+ A label
+</button>
+
+<button href="http://example.com" class="foo expand bar">
+ A label
+</button>