Update configSchema.xml

[sasaraf]

disable the dynamic configuration reload default

[ghost]

@yairogen Could you please take a look? Why is it on by default? what will happen if we'll turn it off.

[yairogen]

@nahsh if you turn it off - you will have to restart the process if you change values in the config file.

configuration/configuration-lib/src/main/java/com/cisco/oss/foundation/configuration/DynamicReloadSupport.java

Line 60 in c5bd171

if (isDynamicReLoadEnabled) {

[sasaraf]

Hi Yair, :)! ok. we don't mind to keep this feature. however, we would like to extend the PR to the following: to allow us to control (by default as part of our configSchema.xml) what will be our default setting for our services. That is, to load the configuration properties from the resources 'configSchema.xml' in an order that will give our services configSchema.xml priority. We tried override this configuration in our configSchema. but the CompositeConfiguration class does 'getProperty' first on the configuration-lib configSchema and keep returning the default origin value. overriding it only as part of config.properties is error prune on our behalf.

public Object getProperty(String key) { Configuration firstMatchingConfiguration = null; for (Configuration config : configList) { if (config.containsKey(key)) { firstMatchingConfiguration = config; break; } }

The firstmatching is in the origin order of the configList instead of opposite. if i open such PR will you approve?

[KerenSi]

@yairogen tagging Yair :)

[sasaraf]

Thanks @KerenSi ;)

[yairogen]

Create the pr and I'll take a look

…

On Mon, Jul 16, 2018, 12:58 KerenSi ***@***.***> wrote: @yairogen <https://github.com/yairogen> tagging Yair :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEh04-An_6gwxXw8OC3XqQ8K-OYuZPjHks5uHGOwgaJpZM4VGx-i> .

[sasaraf]

ok. i see now it is internal getProperty of apache ConfigurationConfiguration extension .so it will require managing the configList in reversed order. will take me more than couple of minutes to do the actual change. hopefully i will get to it by the end of this week b'h.

[yairogen]

reverse order will probably prevent the external config from overriding config from jar. not good.

…

On Mon, Jul 16, 2018 at 1:21 PM sasaraf ***@***.***> wrote: ok. i see now it is internal getProperty of apache ConfigurationConfiguration extension .so it will require managing the configList in reversed order. will take me more than couple of minutes to do the actual change. hopefully i will get to it by the end of this week b'h. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEh04wEXpPLcm4HCRu8b1myGX4saRYoHks5uHGkRgaJpZM4VGx-i> .

[sasaraf]

the config.properties will be kept always on top. you are right. we should pay notice it is the case. i refer to all other jars. thanks for the clarification.

…

On Tue, Jul 17, 2018 at 9:02 AM Yair Ogen ***@***.***> wrote: reverse order will probably prevent the external config from overriding config from jar. not good. On Mon, Jul 16, 2018 at 1:21 PM sasaraf ***@***.***> wrote: > ok. i see now it is internal getProperty of apache > ConfigurationConfiguration extension .so it will require managing the > configList in reversed order. will take me more than couple of minutes to > do the actual change. hopefully i will get to it by the end of this week > b'h. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > < #7 (comment) >, > or mute the thread > < https://github.com/notifications/unsubscribe-auth/AEh04wEXpPLcm4HCRu8b1myGX4saRYoHks5uHGkRgaJpZM4VGx-i > > . > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ASRHDZBhlTYOLy5K0HRtOEx8HLBmp4RIks5uHX3igaJpZM4VGx-i> .