Refactored the entire API of the library #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrote the entire user facing API of the library. Major changes: - all the shapes and transformations are in TitleCase: Circle, Rectangle etc. - The + operator is used to combine shapes - The | operator is used to apply transformations, allowing chaining of transformations - Using Point object wherever makes sense instead of just x and y Issue #2
closes #3
Also updated all the images used in README.
Changed the default width and height to 200 and 100 to make the default shape look like a rectangle. Updated the examples and tests accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1 and #2.
Changes:
Closes #1, #2, #3 and #8