-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set up configuration to input subproject's urls and docpath #167
Conversation
@imujjwal96 @Sch00lb0y Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Can you show how these Env Vars would look with your example yaml |
@imujjwal96 I have updated the description with the output |
@pri22296 any token to check if subprojects exist? Or the presence of values in these two env vars is enuff? |
That logic would have to be handled by the script which clones the subprojects. I think config.py should be limited to reading values from |
@pri22296 What about the name of the subprojects? |
For now let's default with the repository name? or maybe i could add an extra field for it and default it with reponame extracted from the url? any other fields we should expose in the subproject section? |
I don't think so |
okay a query! where would we need the subproject's name in the build process? |
I guess we won't 👌 |
Description
SUBPROJECT_URLS
andSUBPROJECT_DOCPATHS
which would containcomma
seperated urls and docpaths respectively.A user would be able to set it from the
.yaydoc.yml
file like thisResultant output
Related Issue
#160
Motivation and Context
This is required so that user's would be easily able to specify subprojects
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Fixes #<number> commit message