-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed issue where large image would render in different env #891
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nice simple fix to a longstanding problem. Thanks for taking this on @Aryanamish!
Hm I'm unsure why the tests are failing here, it may be a good idea to rebase then regen the minified frontend. |
Great bugfix! As a side-note:
|
Updated the backend to send envID with the render information. Updated the Front End to ignore the incoming window when it is not in the current selected environment
I fixed the linting error |
The failing of the functional test seems legitimate to me: Reason is that the state of each window does not yet adapt to the new The Python Linter-Error can be fixed easily. The visual regression tests: see update below. Regarding the other failing tests:
Best, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving to a change request based on @da-h's analysis.
Updated the backend to send the environment ID with the render information.
Updated the Front End to ignore the incoming window when it is not in the currently selected environment
Motivation and Context
issue #80
Types of changes
Checklist:
py/visdom/VERSION
according to Semantic Versioning