Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] add click callback for textPane #868

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

[feat] add click callback for textPane #868

wants to merge 11 commits into from

Conversation

shouldsee
Copy link
Contributor

@shouldsee shouldsee commented Sep 27, 2022 •
edited
Loading

Description

Motivation and Context

Would like to trigger event in business py script upon clicking a text pane. Needs a rebase before merge. (only merge 7cbb7c4)

How Has This Been Tested?

no test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@shouldsee
refactor data storage to allow saving on a per-window basis
6b46661
@shouldsee
cleaning
860a426
@shouldsee
allows switching caching behaviour by class construction
edc4fd2
@shouldsee
[refactor] half way on autosave: impl abstract xt type
1c556b7
@shouldsee
[refactor] creating infra for auto-saving. ckpt before capturing init…
daacf25 
… events
@shouldsee
[refactor]migrate serialize_env_list_wschema and lazy_read
a22c842
@shouldsee
[refactor] autosave is now working!
ea846c7
@shouldsee
[add,bugfix] adds cmdline -cache_type JPE,JPW,JPWA. fix bugs related …
ff05aa7 
…to these modes

    parser.add_argument('-cache_type', metavar='cache_type', type=str,
                        default=DEFAULT_CACHE_TYPE,
                        help='''specify how the received data should be synced
                        between memory and disk.
                          - JPE/OneJsonPerEnv:             one json per environment
                          - JPW/OneJsonPerWindow:          one json per window
                          - JPWA/OneJsonPerWindowAutoSave: one json per window,
                                                           autosave to disk when plotting''')
@shouldsee
[files] for Makefile
efc049e
@shouldsee
__delitem__ now triggers file deletion in JWPA. strict error in demo.py
cb5cb9f
@shouldsee
[adds] TextPane click callback
7cbb7c4
JackUrb
JackUrb reviewed Dec 2, 2022
View reviewed changes
Copy link
Contributor

@JackUrb JackUrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having trouble isolating the different changes between what's here in #868 and what is part of #862. The latter is a much harder change to review, especially with the server itself in refactor. Will leave some notes in there as well.

@shouldsee
Copy link
Contributor Author

Ah sorry I was not very good at separating commits. I think 7cbb7c4 is pretty much enough for the front end. Just needs to add test to make sure backend correctly process this event.

@JackUrb JackUrb mentioned this pull request Dec 6, 2022
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackUrb JackUrb JackUrb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shouldsee @JackUrb