-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Big change][WIP] Server refactor #675
Open
JackUrb
wants to merge
12
commits into
master
Choose a base branch
from
server-refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
server.py
file gradually grew from a bootstrapped tornado copy-paste into a full fledged server, but at no point had it ever been truly refactored. As such, the whole application was somewhat difficult to understand or debug, and making contributions to the server wasn't particularly clear.This PR aims to refactor the server in a number of ways, with a few core changes that will be coming up in follow-on PRs that I will merge into this branch as they are accepted.
Explanation of changes
This specific PR starts the process by making 0 code logic changes. It simply splits up what used to be ~2000 lines of mostly undocumented code in one file into ~2000 lines of now documented code in separate files that describe their purposes.
Upcoming refactor steps
server.py
file into a number of more self-contained classesdata_model
that will abstract the operations that the server does on panes away from being directly in control of the handlers. Handlers should not be dereferencing arbitrary dicts. Move some of theserver_utils
into appropriate places following this.socket_handlers
to use this new functionality.web_handlers
.__init__.py
.How Has This Been Tested?
Ran demo.py, all of the panes plot as expected. Will continue to test as such for each step.
python -m visdom.server
still functions as expected as well.Types of changes
Checklist: