Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed grid alignment #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed grid alignment #19

wants to merge 1 commit into from

Conversation

Dishebh
Copy link
Member

@Dishebh Dishebh commented Dec 15, 2019 •
edited
Loading

  • Included a Preview link and screenshot showing after and before the changes.
  • Included a description of the change below.
  • Squashed the commits.

Changes done in this Pull Request

Description / Changes

Fixed the page responsiveness issue by aligning each card a specific a height.

Screenshots if any:

Before:

issue1
issue2

After:

Screenshot from 2019-12-16 01-42-55
Screenshot from 2019-12-16 01-43-02

@Dishebh Dishebh closed this Dec 15, 2019
@Dishebh Dishebh reopened this Dec 15, 2019
mariobehling
mariobehling requested changes Dec 22, 2019
View reviewed changes
Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview Link not working.

@Dishebh
Copy link
Member Author

Dishebh commented Dec 23, 2019

@mariobehling here's the preview link:
https://dishebh.github.io/summit.fossasia.org/

mariobehling
mariobehling requested changes Dec 23, 2019
View reviewed changes
Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes result in increased white area. Unused white space in some rows now.

Screenshot from 2019-12-23 12-36-32

@Dishebh
Copy link
Member Author

Dishebh commented Dec 23, 2019

@mariobehling what about now?
https://dishebh.github.io/summit.fossasia.org/

@mariobehling
Copy link
Member

Does not look like the right approach. I think we can just shorten the text. I will work on this in a bit.

@Dishebh
Copy link
Member Author

Dishebh commented Dec 23, 2019

Cool, just let me know if I can help somehow, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariobehling mariobehling mariobehling requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Page Responsiveness
2 participants
@Dishebh @mariobehling