-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: configure workflows for Flutter app #2562
Conversation
Reviewer's Guide by SourceryThis PR restructures the GitHub Actions workflows to support a Flutter application, introducing separate workflows for Android and iOS builds. The implementation splits the build process into three main components: a common workflow for shared tasks, and platform-specific workflows for Android and iOS. The common workflow handles Flutter setup, dependency management, code formatting, analysis, and testing, while platform-specific workflows manage their respective build processes. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @AsCress - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Add validation or warning for empty credential defaults (link)
Overall Comments:
- Could you clarify the plan for handling releases? The removal of push-event.yml and release.yml workflows suggests these scenarios aren't covered yet.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🔴 Security: 1 blocking issue
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
8129f84
to
c35c724
Compare
#2566 should be merged before this. |
c35c724
to
df6fff5
Compare
Build successful. APKs to test: https://github.com/fossasia/pslab-android/actions/runs/11745130532/artifacts/2163841312 |
Configures the basic workflow infrastructure to make the
flutter
branch ready for contributions.Changes
Screenshots / Recordings
N/A
Checklist:
strings.xml
,dimens.xml
andcolors.xml
without hard coding any value.strings.xml
,dimens.xml
orcolors.xml
.Summary by Sourcery
Configure CI workflows for the Flutter branch by adding new workflows for Android and iOS builds and removing existing workflows triggered on push events or releases.
CI: