-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added APDS9960 Gesture, Color, Proximity and Ambient Light Sensor #2539
Conversation
Build successful. APKs to test: https://github.com/fossasia/pslab-android/actions/runs/10488547203/artifacts/1836877047 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @AsCress - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 4 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
I successfully tested the sensor (proximity, color and light sensing) with the v5 board and the v3.0.2 firmware. We agreed that gestures will be added in a future PR. |
83104c8
to
eec870a
Compare
@CloudyPadmal @marcnause @bessman Screen_recording_20240821_160744.mp4@marcnause Could you also please test these features with the sensor and confirm that they work fine? P.S.- Please ignore the issues found out by static code analysis as they are complexity related and we can't do much to reduce the complexity when the driver functionality requires that (ported from the adafruit driver). |
Build successful. APKs to test: https://github.com/fossasia/pslab-android/actions/runs/10548067408/artifacts/1851922955 |
Yay! 🥳 I tested the sensor again and I can confirm that the gesture detection is working fine with my sensor and is fun to use. 😉 I think that Would it be possible to increase the width of the |
@marcnause Thanks for testing! Your suggestions regarding the layout are nice ones! I've updated the layout accordingly. Even if we refactor the |
@AsCress Thumbs up for the changed layout! I think it looks really good. |
@marcnause Is there something that you would like to discuss regarding this PR or maybe give it a final review ? This is ready to be merged from my side. |
Adds support for the APDS9960 Gesture, Color, Proximity and Ambient Light Sensor.
The APDS9960 is a versatile digital, RGB, ambient light, proximity, and gesture sensor.
Some of its features: -
1. RGB Color Sensing: It can accurately measure red, green, and blue (RGB) light levels, allowing it to detect and differentiate between different colors in the environment.
2. Ambient Light Sensing: It includes an ambient light sensor capable of measuring the intensity of ambient light.
3. Proximity Sensing: It can detect the presence of objects or obstacles in close proximity to the sensor. It emits infrared (IR) light and measures the reflection to determine the distance between the sensor and nearby objects.
4. Gesture Detection: One of its standout features is its ability to recognize a variety of hand gestures, such as swipe, flick, and circle motions.
Changes
Screenshots / Recordings
Here is a screen recording demonstrating the functioning: -
Screen_recording_20240819_201444.mp4
Checklist:
strings.xml
,dimens.xml
andcolors.xml
without hard coding any value.strings.xml
,dimens.xml
orcolors.xml
.Note:-
This has been tested with the sensor.
@marcnause Could you please also test this and confirm if this works fine ?
Summary by Sourcery
Introduce support for the APDS9960 sensor, including gesture, color, proximity, and ambient light sensing. Develop a new communication library and user interface for the sensor, enhancing the application's sensor capabilities.
New Features:
Enhancements: