Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed crash in PowerSourceActivity by adding checks to input values #2485

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

AsCress
Copy link
Contributor

@AsCress AsCress commented Jun 15, 2024

Fixes #2484

Changes

  • Adds checks to values input through EditTexts in the PowerSourceActivity to check whether they are float parseable or not. Resets voltage value to default in the later case.

Screenshots / Recordings

Screen_recording_20240615_213310.mp4

Checklist:

  • No hard coding: I have used resources from strings.xml, dimens.xml and colors.xml without hard coding any value.
  • No end of file edits: No modifications done at end of resource files strings.xml, dimens.xml or colors.xml.
  • Code reformatting: I have reformatted code and fixed indentation in every file included in this pull request.
  • No extra space: My code does not contain any extra lines or extra spaces than the ones that are necessary.

@marcnause Could you please confirm if this issue is completely fixed now ?

@AsCress AsCress added the Fix Solution to an existing issue in app label Jun 15, 2024
@marcnause marcnause merged commit 510ccdc into fossasia:development Jun 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Solution to an existing issue in app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PowerSourceActivity: App crashes on entering an invalid value
2 participants