Wave Generator: Implement option to generate waves without PSLab Device #1976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dwlsalmeida how is it going. Would be great to get this feature in. Would love to see the next steps. |
|
Hey @mariobehling This is semi-working. Might as well give it another go today. Did you try it out? I'd appreciate some feedback. Sent from my Redmi Note 5 using FastHub |
Signed-off-by: Daniel W. S. Almeida <[email protected]>
dwlsalmeida
force-pushed
the
phone-wave-generator
branch
from
19647dd
to
04ddfa7
Compare
|
@mariobehling @CloudyPadmal can I get someone to look this over? I have implemented a radio button that checks whether there's anything hooked up into the audio jack before playing the signal. What now? Any guidance is appreciated, thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel W. S. Almeida [email protected]
First steps for #1974
This is not ready yet.
Current code crashes with java.lang.IllegalStateException: Unable to retrieve AudioTrack pointer for write() . I will investigate.I would appreciate some feedback on this, specially as I am not sure whether I have understood the task 100%. I have based my work on this blog post.
Changes:
Add a button to generate waves without a PSLab device, using the phone as the source for the signal. Refactor existing sampling code from its current implementation in ProduceSoundTask into a separate method for code reuse.
Checklist:
strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xml