Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]DHT11 support added #1844

Closed
wants to merge 1 commit into from
Closed

[WIP]DHT11 support added #1844

wants to merge 1 commit into from

Conversation

ho-dor
Copy link
Contributor

@ho-dor ho-dor commented Jun 30, 2019

Fixes #1172

Changes: Adding support for DHT11

Screenshot/s for the changes: N/A

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing:N/A

@neel1998
Copy link
Member

neel1998 commented Jun 30, 2019

@ho-dor i don't think 0x0f is the correct I2C address for DHT11 sensor. I checked on this link where address for all I2C sensors are specified https://learn.adafruit.com/i2c-addresses/the-list . @CloudyPadmal please guide. Also some of the sensors in #1840 are not I2C. How to communicate with such sensors?

@ho-dor
Copy link
Contributor Author

ho-dor commented Jul 1, 2019

@neel1998 what about DHT11, is it i2c? It's not in the list you have mentioned

@neel1998
Copy link
Member

neel1998 commented Jul 1, 2019

@ho-dor i am not sure. But mostly all the i2c sensors have SDA and SCL pins. Which are not there in DHT11. Still we have to check once. But mostly it might not be i2c

@CloudyPadmal
Copy link
Collaborator

DHT11 is not an I2C sensor. Checkout Arduino library and see how it's implemented.

private I2C i2c;

public DHT11(I2C i2c, ScienceLab scienceLab) throws IOException, InterruptedException {
this.i2c = i2c;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not I2C

@CloudyPadmal CloudyPadmal added the Invalid This is no longer relevant label Jul 1, 2019
@CloudyPadmal
Copy link
Collaborator

I suggest we close this for now and work on it later. DHT11 sensor works in a different principle and I think a direct firmware support would be more appropriate than trying hard with Android. I'll follow up with this issue later and closing this for now

@CloudyPadmal CloudyPadmal added the Status: Blocked Cannot carry out further development label Jul 3, 2019
@ho-dor ho-dor deleted the dht11 branch July 5, 2019 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Invalid This is no longer relevant Status: Blocked Cannot carry out further development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement DHT11 Temperature/Humidity sensor
3 participants