Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add space around brackets #274

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

odkhang
Copy link
Collaborator

@odkhang odkhang commented Nov 15, 2024

Implement adding a space before the opening bracket and after the closing bracket in a Vue project. For example: { contact_request }.

Summary by Sourcery

Enhancements:

  • Add spaces around brackets in Vue components to improve code readability and consistency.

Copy link

sourcery-ai bot commented Nov 15, 2024

Reviewer's Guide by Sourcery

This pull request implements consistent spacing around brackets in Vue template expressions and JavaScript objects throughout the codebase. The changes add a space after opening brackets and before closing brackets to improve code readability. For example, changing :class="{active: true}" to :class="{ active: true }" and import {Janus} from 'janus-gateway' to import { Janus } from 'janus-gateway'.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Add consistent spacing around curly braces in Vue template expressions
  • Add space after opening brace and before closing brace in :class bindings
  • Add space after opening brace and before closing brace in :style bindings
  • Add space after opening brace and before closing brace in v-slot scoped slots
webapp/src/components/janus/JanusConference.vue
webapp/src/components/janus/JanusVideoroom.vue
webapp/src/components/RoomsSidebar.vue
webapp/src/views/schedule/schedule-components/GridSchedule.vue
Add consistent spacing around curly braces in JavaScript imports and object literals
  • Add space after opening brace and before closing brace in destructured imports
  • Add space after opening brace and before closing brace in object literals
  • Add space after opening brace and before closing brace in destructured function parameters
webapp/src/components/janus/JanusConference.vue
webapp/src/components/janus/JanusVideoroom.vue
webapp/src/views/schedule/schedule-components/Session.vue
webapp/src/views/admin/config/index.vue

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@odkhang odkhang marked this pull request as ready for review November 18, 2024 10:20
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @odkhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants