-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update YouTube URL with Additional Parameters #177
Conversation
Reviewer's Guide by SourceryThis pull request enhances the YouTube embedding functionality in the MediaSource component by updating the URL construction to include additional parameters such as enablejsapi, autoplay, modestbranding, loop, controls, disablekb, rel, showinfo, and playlist. The changes also switch to using the no-cookie URL for privacy-friendly embedding. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @untari - I've reviewed your changes - here's some feedback:
Overall Comments:
- The changes look good and achieve the desired functionality. For future improvements, consider creating a dedicated function for constructing the YouTube URL with parameters. This could enhance maintainability and reduce code duplication.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Please also implement switch buttons for the features. This will also help users to see what features are available. In the previous version of this feature there were switch buttons. A switch button or other button would be expected for these features here as well. For example I am not clear how to use the no cookie domain as a URL parameter otherwise. There are example of a switch button on this page already. |
I merged this as it solves some issues, but we need the switch buttons as well. |
Hi @mariobehling will open new pr for the switch button |
This PR is for issues: #170
This PR enhances the YouTube embedding functionality in the media source component by updating the URL construction to include additional parameters. The changes ensure that the YouTube videos are embedded with the following options:
enablejsapi=1
)autoplay=1
)modestbranding=1
)loop=1
)controls=0
)disablekb=1
)rel=0
)showinfo=0
)https://www.youtube-nocookie.com
)playlist=${ytid
)Summary by Sourcery
This pull request enhances the YouTube embedding functionality by updating the URL construction to include parameters such as enabling JavaScript API, autoplay, modest branding, looping, hiding controls, disabling keyboard controls, hiding related videos, hiding video info, and using no-cookies. These changes ensure a more controlled and customized embedding experience.