Theme config does not take effect #155
Conversation
lcduong
commented
Jul 16, 2024
•
lcduong
commented
|
Note: for upload logo file, [urls] [media] must be configured in config file since /media is expose by server app, so need to config nginx for expose via webapp. |
server/venueless/zoom/views.py
Outdated
| @@ -53,7 +54,8 @@ def get_closest_zoom_lang(world): | |||
| class ZoomViewMixin: | |||
| @cached_property | |||
| def world(self): | |||
| w = get_object_or_404(World, domain=self.request.headers["Host"]) | |||
| world_domain = re.sub(r":\d+$", "", self.request.headers["Host"]) | |||
There was a problem hiding this comment.
Please use Django's built-in request.get_host().
server/venueless/api/views.py
Outdated
| @return: theme data of a world | ||
| """ | ||
| world = get_object_or_404(World, id=kwargs["world_id"]) | ||
| return Response(WorldSerializer(world).data['config']['theme']) |
|
I think it is not safe to assume that the API response is always in the shape that the frontend expects (like missing some fields, or different data type). In the future, when we can migrate our frontend to Vue 3 + TypeScript, this "validation step" will be mandatory, because not only it help developers to find where data is wrong, but also provide type information (TypeScript) for IDE to produce good autocomplete. |
| try: | ||
| world = get_object_or_404(World, id=kwargs["world_id"]) | ||
| return Response(WorldSerializer(world).data['config']['theme']) | ||
| except KeyError: |
There was a problem hiding this comment.
If KeyError happens, it means that us, the website owner, did not prepare enough data, or misconfigured the website. We need to do logger.error to inform our team.
For end user, we can throw error 503 to tell that this error is our side, temporary and can work again in the future.
server/venueless/api/views.py
Outdated
| world = get_object_or_404(World, id=kwargs["world_id"]) | ||
| return Response(WorldSerializer(world).data['config']['theme']) | ||
| except KeyError: | ||
| logger.error(f"error happened when trying to get theme data of world: " + kwargs["world_id"]) |
There was a problem hiding this comment.
Incorrect use of logger. Check guide in fossasia/eventyay-talk#130
