Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement organizer onboarding process | Check if Organizer has unpaid invoice #444

Merged

Conversation

lcduong
Copy link
Contributor

@lcduong lcduong commented Nov 21, 2024

This PR partly resolves issue #379 Implement organizer onboarding process

This PR implement:

  • Add a condition in checking step when public Event: Not allow Event to be published if Organizer has unpaid invoice (which status is pending or expired).

image

Summary by Sourcery

New Features:

  • Implement a check to prevent event publication if the organizer has unpaid invoices.

Copy link

sourcery-ai bot commented Nov 21, 2024

Reviewer's Guide by Sourcery

This PR implements a validation check that prevents event organizers from publishing events if they have any unpaid or expired invoices. The implementation adds a new method to check for unpaid invoices in the Organizer model and uses it as part of the event's live issues validation.

Sequence diagram for event publication check

sequenceDiagram
    actor Organizer
    participant Event
    participant BillingInvoice
    Organizer->>Event: Request to publish event
    Event->>Organizer: Check has_unpaid_invoice()
    Organizer->>BillingInvoice: Query unpaid invoices
    BillingInvoice-->>Organizer: Return invoice count
    alt Unpaid invoices exist
        Event-->>Organizer: Reject publication
    else No unpaid invoices
        Event-->>Organizer: Allow publication
    end
Loading

File-Level Changes

Change Details Files
Added functionality to check for unpaid organizer invoices
  • Implemented has_unpaid_invoice() method that checks for invoices with pending or expired status
  • Added validation in live_issues() to prevent event publication if organizer has unpaid invoices
src/pretix/base/models/event.py
src/pretix/base/models/organizer.py

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lcduong - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using constants or enums instead of magic strings 'n' and 'e' for invoice status checks to improve code maintainability
  • Please add tests to verify the unpaid invoice checking behavior, especially around event publishing restrictions
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

src/pretix/base/models/organizer.py Outdated Show resolved Hide resolved
@mariobehling mariobehling merged commit cddebe6 into fossasia:development Nov 21, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants