-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement organizer onboarding process | Pricing/Privacy/Terms Pages #434
base: development
Are you sure you want to change the base?
Conversation
… and show it on signup page
Reviewer's Guide by SourceryThis PR implements functionality to manage content pages (Pricing/Privacy/Terms) in the admin area and display them on the login/register page. The implementation uses Quill editor for rich text editing and includes proper content sanitization. Class diagram for the new PageSettingsForm and PageCreate classesclassDiagram
class PageSettingsForm {
+GlobalSettingsObject obj
+String page_name
+clean() I18nFormField
+_clean_content_field(content_field) I18nFormField
+_store_image(image_src) String
}
class PageCreate {
+get_form_kwargs() kwargs
+get_context_data() ctx
+form_valid(form) success
+form_invalid(form) error
+get_success_url() url
}
PageCreate --> PageSettingsForm
note for PageSettingsForm "Handles form logic for page settings"
note for PageCreate "View for creating and updating page content"
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lcduong - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding access controls to the uploaded images storage to prevent unauthorized access. The current implementation stores them with public access which could be a security concern.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟡 Security: 1 issue found
- 🟢 Testing: all looks good
- 🟡 Complexity: 2 issues found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Please resolve conflicts. |
Hi @mariobehling, conflict is resolved |
…tickets into feat-379-welcome-pages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the implementation I recommend to follow the example of the pages module for organisers more closely. Find more details here #379 (comment) |
This PR is part of issue #379 Implement organizer onboarding process
It implement:
Summary by Sourcery
Implement a new admin page for managing Pricing, Privacy, and Terms content, and integrate Quill Editor for rich text editing.
New Features:
Enhancements:
Documentation: