-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement organizer onboarding process | Validate condition to public Event #429
Implement organizer onboarding process | Validate condition to public Event #429
Conversation
Reviewer's Guide by SourceryThis PR implements part of the organizer onboarding process by adding billing settings functionality and validation for event publication. The implementation includes a new billing settings form with Stripe integration for payment management, and prevents events from being published if the organizer's billing information and credit card details are not properly configured. Class Diagram for Billing Settings and Stripe IntegrationclassDiagram
class OrganizerBillingModel {
+String primary_contact_name
+String primary_contact_email
+String company_or_organization_name
+String address_line_1
+String address_line_2
+String city
+String zip_code
+String country
+String preferred_language
+String tax_id
+String stripe_customer_id
+String stripe_payment_method_id
+String stripe_setup_intent_id
+save()
+delete()
}
class BillingSettingsForm {
+CharField primary_contact_name
+EmailField primary_contact_email
+CharField company_or_organization_name
+CharField address_line_1
+CharField address_line_2
+CharField zip_code
+CharField city
+ChoiceField country
+ChoiceField preferred_language
+CharField tax_id
+set_initial_data()
+save()
}
class StripeUtils {
+create_stripe_customer(email, name)
+update_customer_info(customer_id, email, name)
+create_setup_intent(customer_id)
+update_payment_info(setup_intent_id, customer_id)
+get_payment_method_info(stripe_customer_id)
}
OrganizerBillingModel --> BillingSettingsForm
BillingSettingsForm --> StripeUtils
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lcduong - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please add test coverage for the Stripe integration and payment processing flows to ensure reliability of these critical payment features.
- Consider adding documentation about security considerations and data handling, particularly around the storage and processing of sensitive payment information.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 2 issues found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This PR partly resolves issue #379 Implement organizer onboarding process
This PR implement:
Note: Depend on this PR #411
Summary by Sourcery
Implement organizer onboarding process with a new billing settings form and Stripe integration for payment management. Prevent event publication if billing information is incomplete.
New Features:
Enhancements:
Build:
Summary by Sourcery
Implement organizer onboarding process with a new billing settings form and Stripe integration for payment management. Prevent event publication if billing information is incomplete.
New Features:
Enhancements:
Build: