Update document: Nginx & URLs path #427
Conversation
Reviewer's Guide by SourceryThis PR adds a new documentation file that explains the configuration of Nginx and URL paths for test and live server environments. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @lcduong - I've reviewed your changes - here's some feedback:
Overall Comments:
- The PR appears to be incomplete - please add the actual documentation content to the new file before requesting review.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| ssl_certificate /etc/../fullchain.pem; | ||
| ssl_certificate_key /etc/../privkey.pem; | ||
| include /etc/../options-ssl-nginx.conf; | ||
| ssl_dhparam /etc/../ssl-dhparams.pem; |
There was a problem hiding this comment.
issue (documentation): The '/etc/../' path appears to be a placeholder and should be replaced with the actual path
Consider using '/etc/letsencrypt/live/domain.com/' or documenting that this needs to be replaced with the actual certificate path
|
|
||
| With this setup: | ||
|
|
||
| - The URL for accessing the ``eventyay-tickets`` application control panel is ``https://app-test.eventyay.com/tickets/control``. |
There was a problem hiding this comment.
The documentation should be URL agnostic. If we deploy this somewhere else it does not make sense.
|
|
||
| server { | ||
| listen 80; | ||
| server_name app-test.eventyay.com; |
There was a problem hiding this comment.
The documentation should be URL agnostic. If we deploy this somewhere else it does not make sense.
|
|
||
| - **/tickets**: | ||
| - This location is for the ``eventyay-tickets`` application. | ||
| - Requests to ``https://app-test.eventyay.com/tickets/`` are proxied to ``localhost:8455/``. |
There was a problem hiding this comment.
The documentation should be URL agnostic. If we deploy this somewhere else it does not make sense.
Update documents for how Nginx and URLs path are configured on test/live servers.
Summary by Sourcery
Documentation: