Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement set pricing options at global_setting #418

Merged
merged 10 commits into from
Nov 21, 2024

Conversation

odkhang
Copy link
Collaborator

@odkhang odkhang commented Oct 29, 2024

This PR related to issue #381
New Features:

  • Add a new field 'ticket_fee_percentage' to the global settings form, allowing users to set a percentage fee for each ticket sold.

Copy link

sourcery-ai bot commented Oct 29, 2024

Reviewer's Guide by Sourcery

The PR adds a new decimal field to the global settings form to allow setting a ticket fee percentage. The implementation extends the existing form fields using an OrderedDict to maintain field order.

Class diagram for updated global settings form

classDiagram
    class GlobalSettingsForm {
        +DecimalField ticket_fee_percentage
    }
    note for GlobalSettingsForm "A new field 'ticket_fee_percentage' has been added to set a percentage fee for each ticket sold."
Loading

File-Level Changes

Change Details Files
Added a new ticket fee percentage field to the global settings form
  • Created a new DecimalField with label 'Ticket fee percentage'
  • Added help text explaining that the fee will be charged per ticket sold
  • Set the field as optional (required=False)
  • Added validation to ensure the percentage is non-negative
  • Appended the new field to existing form fields using OrderedDict to preserve order
src/pretix/control/forms/global_settings.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@odkhang
Copy link
Collaborator Author

odkhang commented Oct 29, 2024

Screenshot 2024-10-29 165932

@odkhang odkhang marked this pull request as ready for review October 29, 2024 10:10
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @odkhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

src/pretix/control/forms/global_settings.py Show resolved Hide resolved
@odkhang odkhang requested a review from hongquan October 29, 2024 10:40
@mariobehling mariobehling merged commit 2609bf5 into fossasia:development Nov 21, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants