Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies for migration files #5

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

lcduong
Copy link
Contributor

@lcduong lcduong commented Oct 16, 2024

As customer feature will be removed from eventyay-tickets, to exhibitor migration should depend on other migration file.

Summary by Sourcery

Enhancements:

  • Update migration dependencies for exhibitor migrations to depend on 'pretixbase' initial migration instead of customer table creation.

Copy link
Contributor

sourcery-ai bot commented Oct 16, 2024

Reviewer's Guide by Sourcery

This pull request updates the dependencies in migration files for the exhibitors app. The changes are made to align with the removal of the customer feature from eventyay-tickets.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Update migration dependencies to remove reference to customer table
  • Change dependency from 'pretixbase.0004_create_customer_table' to 'pretixbase.0001_initial'
  • Update dependency in both initial and subsequent migration files
exhibitors/migrations/0001_initial.py
exhibitors/migrations/0002_alter_exhibitorinfo_lead_scanning_enabled_and_more.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lcduong - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please provide more context about this change. How does it relate to the removal of the customer feature, and are there any steps required for existing installations?
  • Have these migration changes been tested on both new and existing databases to ensure they don't cause any issues during the migration process?
  • Consider adding comments in the migration files to explain the reason for this dependency change and any potential impacts it may have.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@mariobehling mariobehling merged commit fcbea7d into fossasia:master Oct 21, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants