Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule page menu shows two items highlighted #209

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

lcduong
Copy link
Contributor

@lcduong lcduong commented Sep 27, 2024

This PR closes/references issue #204 . It does so by checking current page using request.path_info instead of request.path

image

image

How has this been tested?

Checklist

  • I have added tests to cover my changes.

Summary by Sourcery

Resolve the issue of multiple menu items being highlighted on the schedule page by updating the logic to use request.path_info for current page detection.

Bug Fixes:

  • Fix the issue where two menu items were highlighted simultaneously on the schedule page by using request.path_info instead of request.path to determine the current page.

Copy link

sourcery-ai bot commented Sep 27, 2024

Reviewer's Guide by Sourcery

This pull request addresses issue #204 by modifying the way the current page is checked in the schedule page menu. The change involves replacing request.path with request.path_info to correctly highlight the active menu item.

No sequence diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Replace request.path with request.path_info for active menu item detection
  • Update condition for 'Schedule' menu item
  • Update condition for 'Sessions' menu item
  • Update condition for 'Speakers' menu item
src/pretalx/agenda/templates/agenda/header_row.html
Minor whitespace adjustment
  • Remove trailing whitespace in calendar icon line
src/pretalx/agenda/templates/agenda/header_row.html

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lcduong - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@mariobehling mariobehling merged commit d7f603e into fossasia:development Sep 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants