Re-commit filter feature + fix session type label + update calendar view for mobile #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request implements three main changes: 1) It adds a session type label to the schedule data, 2) It updates the calendar view for mobile devices, and 3) It re-commits a filter feature (though details about this are not visible in the provided diff). The changes primarily affect the schedule model and the CSS layout. File-Level Changes
Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @lcduong - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding tests to cover these changes, especially for the new session type formatting in the schedule model.
- The session type string formatting in
build_datacould potentially be refactored for better readability and maintainability. Consider using a formatted string or a separate method for this.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| @@ -669,7 +669,11 @@ def build_data(self, all_talks=False, filter_updated=None, all_rooms=False): | |||
| "state": talk.submission.state if all_talks else None, | |||
| "fav_count": count_fav_talk(talk.submission.code) if talk.submission else 0, | |||
| "do_not_record": talk.submission.do_not_record, | |||
| "tags": talk.submission.get_tag() | |||
| "tags": talk.submission.get_tag(), | |||
| "session_type": str(talk.submission.submission_type.name) | |||
There was a problem hiding this comment.
suggestion: Consider separating session type and duration into distinct fields
Separating the session type and duration would provide more flexibility for frontend processing and make it easier to sort or filter based on these attributes independently.
Suggested change
| "session_type": str(talk.submission.submission_type.name) | |
| "session_type": talk.submission.submission_type.name, | |
| "session_duration": talk.submission.submission_type.default_duration, |
|
|
mariobehling
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes/references issue #170 . It does so by …
How has this been tested?
Checklist
Summary by Sourcery
Fix session type label to include both the name and default duration in minutes. Update calendar view for mobile by adding margin to the locales section.
Bug Fixes:
Enhancements: