Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dropdown filter to show rooms, session types. #179

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

lcduong
Copy link
Contributor

@lcduong lcduong commented Aug 8, 2024

This PR closes/references issue #170 . It does so by …

How has this been tested?

Checklist

  • I have added tests to cover my changes.

Summary by Sourcery

Add a dropdown filter to show rooms and session types in the schedule, and include session type information in the schedule data model.

New Features:

  • Add a dropdown filter to show rooms and session types in the schedule.

Enhancements:

  • Include session type information in the schedule data model.

Copy link

sourcery-ai bot commented Aug 8, 2024

Reviewer's Guide by Sourcery

This pull request adds a dropdown filter to show rooms and session types in the schedule model. The changes are implemented by modifying the build_data method in the schedule.py file to include the session type information for each talk.

File-Level Changes

Files Changes
src/pretalx/schedule/models/schedule.py Modified the 'build_data' method to include session type information for each talk.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lcduong - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a test to ensure the new 'session_type' field is correctly populated and returned in the expected format.
  • Please check if this change affects any API documentation or contracts that might need updating to reflect the new field.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@lcduong
Copy link
Contributor Author

lcduong commented Aug 8, 2024

Filter for room, session type and track
no languages filter as there's no language data of session.

image

image

@mariobehling mariobehling merged commit 89860e1 into fossasia:development Aug 8, 2024
3 of 9 checks passed
mariobehling added a commit that referenced this pull request Aug 9, 2024
mariobehling added a commit that referenced this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants