Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule: In sessions with multiple speakers show picture in front of speaker image for each single speaker #164

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

odkhang
Copy link
Collaborator

@odkhang odkhang commented Aug 1, 2024

This PR closes/references issue #135 . It does so by update the css for session view

How has this been tested?

Checklist

  • I have added tests to cover my changes.

Summary by Sourcery

Enhanced the session view to show speaker images in front of each speaker's name for sessions with multiple speakers, improving the visual representation of speaker information.

  • Enhancements:
    • Updated the session view to display speaker images in front of each speaker's name for sessions with multiple speakers.

Copy link

sourcery-ai bot commented Aug 1, 2024

Reviewer's Guide by Sourcery

This pull request addresses issue #135 by updating the CSS for the session view to display the picture in front of the speaker image for each individual speaker in sessions with multiple speakers.

File-Level Changes

Files Changes
src/pretalx/static/agenda/js/pretalx-schedule.js Updated cache identifiers and modified the 'Session.vue' component to enhance the display of speaker images and names in sessions with multiple speakers.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@odkhang
Copy link
Collaborator Author

odkhang commented Aug 1, 2024

image

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @odkhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@mariobehling mariobehling merged commit 75989ed into fossasia:development Aug 1, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants